From a652bbb05eead0803c8d82fd2ce1bbe03a02d644 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Lov=C3=A9n?= Date: Mon, 4 Dec 2017 13:27:04 +0100 Subject: [PATCH] Remove magic numbers --- src/kernel/drivers/vga.c | 8 ++++---- src/kernel/include/vga.h | 5 +++++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/kernel/drivers/vga.c b/src/kernel/drivers/vga.c index 863f9ef..a42107b 100644 --- a/src/kernel/drivers/vga.c +++ b/src/kernel/drivers/vga.c @@ -23,10 +23,10 @@ void vga_init() void movecursor() { - outb(0x3D4, 0x0F); - outb(0x3D5, (uint8_t)(cursor & 0xFF)); - outb(0x3D4, 0x0E); - outb(0x3D5, (uint8_t)((cursor >> 8) & 0xFF)); + outb(VGA_ADDRESS_PORT, VGA_REGISTER_CURSOR_POS_LOW); + outb(VGA_DATA_PORT, (uint8_t)(cursor & 0xFF)); + outb(VGA_ADDRESS_PORT, VGA_REGISTER_CURSOR_POS_HIGH); + outb(VGA_DATA_PORT, (uint8_t)((cursor >> 8) & 0xFF)); } void flush() diff --git a/src/kernel/include/vga.h b/src/kernel/include/vga.h index 8af2110..315fc00 100644 --- a/src/kernel/include/vga.h +++ b/src/kernel/include/vga.h @@ -12,3 +12,8 @@ void vga_init(); void vga_write(char c); + +#define VGA_ADDRESS_PORT 0x3D4 +#define VGA_DATA_PORT 0x3D5 +#define VGA_REGISTER_CURSOR_POS_LOW 0xF +#define VGA_REGISTER_CURSOR_POS_HIGH 0xE